Fixes #38090 - Add filtering to job invocation hosts table #934
Conversation
kmalyjur
force-pushed
the
job-inv-table-sort
branch
from
337fbfb to
1486e97
Compare
kmalyjur
force-pushed
the
job-inv-table-sort
branch
from
1486e97 to
21fe8e2
Compare
| SUCCESS: { id: 'success', title: __('Succeeded') }, | ||
| FAILED: { id: 'failed', title: __('Failed') }, | ||
| PENDING: { id: 'pending', title: __('In Progress') }, | ||
| CANCELLED: { id: 'cancelled', title: __('Canceled') }, |
There was a problem hiding this comment.
Canceled should have 2 Ls -> Cancelled (both right, but we use the 2 L one in REX)
| }); | ||
| setAPIOptions({ | ||
| ...apiOptions, | ||
| params: { search: searchQuery }, |
There was a problem hiding this comment.
Should include the filter search as well, for example if you select a status and then search the status is not included in the search but still shown as selected
kmalyjur
force-pushed
the
job-inv-table-sort
branch
from
21fe8e2 to
8096633
Compare
|
I also removed the custom pagination from the |
| setParamsAndAPI({ | ||
| ...params, | ||
| ...newPagination, | ||
| search: urlSearchQuery, | ||
| }); | ||
| }; | ||
|
|
There was a problem hiding this comment.
this creates a second api call, best to use the new one :)
There was a problem hiding this comment.
nope my bad, something else is causing the second api call, to reproduce: select a status, edit the search, on search submit there are 2 api calls and one is wrong
|
It is a bit unfortunate to map "running" to "Pending" and "pending" to "pending" with lowercase p and a different icon. Does the design say anything about this? |
|
@adamruzicka Actually, the design doesn't mention it. You're right, it looks bad. I'll change it. |
kmalyjur
force-pushed
the
job-inv-table-sort
branch
from
8096633 to
0b9fd6a
Compare
The PR should be ready to be merged |
|
Running jobs dont show hosts, so merging should wait until we see if its the pr or just my env |
|
|
|
@MariaAga I can see them 🤔 |
|
Sadly, yes, the per-host tasks are not created until the job starts running, which makes it a little bit tricky. |
Searching inside scheduled jobs doesn't really work, but at least that's consistent with the old implementation.
kmalyjur
force-pushed
the
job-inv-table-sort
branch
from
0b9fd6a to
9b83abd
Compare
|
js tests are red :/ |
|
js test error make no sense, and dont happen locally, maybe re run them? |
|
It ain't much, but it's honest work |
Sorting and filtering were added to the host table of the new job invocation page.
(Ordering by status is not permitted on purpose.)
Needs Fixes #38134 - Add custom pagination to table