Fixes #SAT-30369 - Registration - Show info for Pull provider #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stejskalleos
force-pushed
the
ls/pull_warning
branch
from
447b287 to
3bf1cfb
Compare
stejskalleos
commented
Jan 8, 2025
stejskalleos
changed the title
Lennonka
suggested changes
Jan 8, 2025
Lennonka
reviewed
Jan 8, 2025
|
@adamruzicka ready for review |
adamruzicka
reviewed
Jan 13, 2025
stejskalleos
force-pushed
the
ls/pull_warning
branch
from
0874c12 to
b01289b
Compare
stejskalleos
force-pushed
the
ls/pull_warning
branch
from
b01289b to
5723005
Compare
stejskalleos
force-pushed
the
ls/pull_warning
branch
from
5723005 to
72cea18
Compare
|
aaand it's 🍏 |
stejskalleos
commented
Jan 21, 2025
| </Alert> | ||
| ); | ||
|
|
||
| function showPullWarning(valueFromParam, value) { |
There was a problem hiding this comment.
Note: The if branching might look weird at first glance, but it's because of:
valueFromParam can be true, false or undefined
value can be 'true', 'false', '' or undefined.
It was fun.
adamruzicka
approved these changes
Jan 21, 2025
|
Thank you @stejskalleos ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.