Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a tomcat upgrade workaround for upgrade pipelines #1703

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

@@ -19,6 +19,8 @@
scenario: "{{ pipeline_type }}"
scenario_os: "{{ pipeline_os }}"
scenario_version: "{{ forklift_upgrade_version_intermediate }}"
- role: update_tomcat
when: pipeline_type == 'katello'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and pipeline_os centos8-stream? Otherwise this will get executed on Alma and fail?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, done.

@ehelms ehelms force-pushed the update-tomcat branch 2 times, most recently from bec9463 to 8c0a9d5 Compare September 10, 2023 12:48
@@ -19,6 +19,8 @@
scenario: "{{ pipeline_type }}"
scenario_os: "{{ pipeline_os }}"
scenario_version: "{{ forklift_upgrade_version_intermediate }}"
- role: update_tomcat
when: pipeline_type == 'katello' && pipeline_os == 'centos8-stream'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, and the luna pipe will have the same problem ;)

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something users should also do?

@ehelms
Copy link
Member Author

ehelms commented Sep 11, 2023

Is this something users should also do?

They will have to to upgrade, see https://community.theforeman.org/t/performing-dnf-update-on-foreman-server-results-in-errors/34959/10

@ehelms ehelms merged commit 0e66c9f into theforeman:master Sep 11, 2023
7 of 8 checks passed
@ekohl
Copy link
Member

ekohl commented Sep 11, 2023

Looks like this broke the pipelines:

[2023-09-11T08:05:33.956Z] fatal: [pipe-up-foreman-nightly-debian11]: FAILED! => 
[2023-09-11T08:05:33.956Z]   msg: |-
[2023-09-11T08:05:33.956Z]     The conditional check '(pipeline_type == 'katello' || pipeline_type == 'luna') && pipeline_os == 'centos8-stream'' failed. The error was: template error while templating string: expected token 'name', got '|'. String: {% if (pipeline_type == 'katello' || pipeline_type == 'luna') && pipeline_os == 'centos8-stream' %} True {% else %} False {% endif %}. expected token 'name', got '|'
[2023-09-11T08:05:33.956Z]   
[2023-09-11T08:05:33.956Z]     The error appears to be in '/home/pipe-debian11-upgrade/forklift/roles/update_tomcat/tasks/main.yml': line 2, column 3, but may
[2023-09-11T08:05:33.956Z]     be elsewhere in the file depending on the exact syntax problem.
[2023-09-11T08:05:33.956Z]   
[2023-09-11T08:05:33.956Z]     The offending line appears to be:
[2023-09-11T08:05:33.956Z]   
[2023-09-11T08:05:33.956Z]     ---
[2023-09-11T08:05:33.956Z]     - name: Set module hotfixes on AppStream
[2023-09-11T08:05:33.956Z]       ^ here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants