Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on FAM for much of the foreman_provisioning setup #1888

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Dec 3, 2024

This isn't tested now and needs some proper review. I'll highlight some questions inline.

Copy link
Member Author

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This together with #1866 can mean we no longer need Hammer and we can drop this bit:

- role: hammer_credentials

I also wonder if we should move this into foreman_provisioning and drop the foreman_provisioning_infrastructure role.

Comment on lines +13 to +16
0:
type: network
network: provision
model: virtio
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evgeni this is taken from the examples in https://theforeman.github.io/foreman-ansible-modules/develop/plugins/compute_profile_module.html#ansible-collections-theforeman-foreman-compute-profile-module but the description says it's a list, so should it be

Suggested change
0:
type: network
network: provision
model: virtio
- type: network
network: provision
model: virtio

@@ -1,126 +1,64 @@
---
# Make sure admin does not default to any taxonomy
- name: 'disable default context for admin'
# TODO: how to pass org and location IDs 0 to FAM?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant