Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for defining custom dnssec-policies #206

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

smortex
Copy link
Contributor

@smortex smortex commented Feb 16, 2022

This is a complement to #205 to allow to setup custom policies.

This is currently a draft until I manage to deploy this code in a real-world workload.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor suggestions, overall it looks good to me.

spec/defines/dns_dnssec_policy_spec.rb Outdated Show resolved Hide resolved
templates/named.dnssec_policy.epp Outdated Show resolved Hide resolved
@smortex smortex marked this pull request as ready for review February 19, 2022 19:43
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not entirely sure.

manifests/dnssec_policy.pp Outdated Show resolved Hide resolved
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, but perhaps @evgeni or @wbclark can weigh in on their preference.

@evgeni
Copy link
Member

evgeni commented Feb 20, 2022

I have no strong opinion (and not too versed in dnssec), but it doesn't look crazy to me? ;)

@smortex
Copy link
Contributor Author

smortex commented Feb 20, 2022

Thanks! I squashed the commits.

@ekohl ekohl merged commit c3bda99 into theforeman:master Feb 22, 2022
@smortex smortex deleted the custom-dnssec-policy branch February 22, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants