add plugin foreman_column_view

[dgoetz]

This PR adds support for the plugin foreman_column_view.

In my tests it worked fine, but there are some points I am not sure about:

• I used Puppet 4+ Datatypes in an excessive way for validation as some other code is already doing this but only in a much more simple way
• I fear using a hash of hashes will not work with kafo, only with Puppet
• I only added the default tests and one positive test for the configuration file, no negative one to fail if configuration is wrong
• Changes of the plugin's configuration require a restart of Foreman which I did not address

Please let me know if something requires a change in the PR.

[dgoetz]

Thanks for the review!
I changed the template to work with columns undefined so I do no longer require the if clause and can use the parameter config.
I moved the data type to a custom data type and added the check.
I also addressed the lint error from the checks, but I have no idea why the test failed now with a timeout.

[dgoetz]

Thanks again!
Removed the undef and optional as it worked fine without it. Managing the file is intended as I checked that only the header is still a valid configuration for the plugin.
Removed the unused variable.
And moved the datatype from a hash with a minimum and maximum numbers of key value pairs (the 3,9) to a defined Struct. Added additional checks while doing so as it took me a while to understand how this should work. But now the checks all fail, while local check run successful (using the puppet 5.3.2 gem). Any idea?

[ekohl]

It does show up with rake lint but I haven't been able to pin it down where exactly. I'll need to dive into it.

[ekohl]

Looking into it comes from https://github.com/theforeman/kafo/blob/master/lib/kafo/data_type.rb but there is a Struct class. Somehow it's parsing Struct[ instead so there might be an issue with the regex.

[ekohl]

I opened https://projects.theforeman.org/issues/21398. Not sure how to easily proceed with this but maybe we can ignore the puppet class that includes it from linting or that particular test.

[dgoetz]

Thanks for all the effort.

[ekohl]

I wonder if we should accept the PR now with a simple type check while we work on the kafo issue.

[dgoetz]

I do not see a need to rush. Column_view is easily installed and configured manually, I just recognized it is the only one missing in the module and installer of those I commonly use. Also it will not make it into 1.16 if merged now, or will it? Furthermore kafo can not handle arrays of hashes, so it will only handle installation and not configuration.

[ekohl]

So the actual problem is https://github.com/theforeman/kafo/blob/93aaa70eff832fc6ccfbcbbf672f5cd775007420/lib/kafo/data_type_parser.rb#L5 which can't parse multi line types. A multi-line regex sounds like a bad idea so we probably need to find a better way. We can probably extract them using puppet-strings and cache them like we do with others.

[ekohl]

This workaround has been on my mind for a while, but I always forgot to comment it here

[ekohl]

Let's see if Travis agrees :)

[dgoetz]

I had to adjust the checks because it needed a different string to match but Travis is green now! 😃

[ekohl]

Thanks!