Convert ipa and sssd facts to structured facts #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has decent test coverage but I still want to test this on an actual system. |
ekohl
force-pushed
the
structured-facts
branch
from
001fc39 to
38f2df0
Compare
Merged
stbenjam
suggested changes
Jan 26, 2018
lib/facter/util/sssd.rb
Outdated
| @@ -16,7 +16,7 @@ def self.ipa_value(path) | |||
| end | |||
|
|
|||
| def self.sssd_value(path) | |||
| aug_value('Sssd.lns', '/etc/sssd/sssd.conf', path) | |||
| aug_value('Sssd.lns', '/etc/sssd/sssd.conf', path).split(',').map(&:strip) | |||
There was a problem hiding this comment.
Get an error here when there's no value in sssd.conf, e.g. I don't have target[.="ifp"]/user_attributes.
Facter: error while resolving custom fact "sssd": undefined method `split' for nil:NilClass
backtrace:
/usr/share/foreman-installer/modules/foreman/lib/facter/util/sssd.rb:19:in `sssd_value'
38f2df0 to
711792a
Compare
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
Updated to properly handle nil values and be somewhat more generic. |
ekohl
force-pushed
the
structured-facts
branch
from
711792a to
b0f88ed
Compare
|
One more update that's tested on an actually subscribed system and fixed one more issue where value was not present. |
|
Ok, looks good and seems to work for me now |
stbenjam
approved these changes
Jan 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #616 and modern puppet tooling