Remove test and development database declarations #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have a |
These database declarations don't make sense in a production environment which the module is focused on. If these environment databases are desired then they can be added back properly. This also serves to fix an odd issue in production with Dynflow.
ehelms
force-pushed
the
remove-databases
branch
from
0f81875 to
944be97
Compare
|
@ekohl Thats a great idea, might open it up for re-use as well in development module |
ekohl
approved these changes
Feb 5, 2018
|
@ekohl One issue with this being the solution for nightly... we'd need this in 1.17 for Katello 3.6 to pass testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These database declarations don't make sense in a production
environment which the module is focused on. If these environment
databases are desired then they can be added back properly. This
also serves to fix an odd issue in production with Dynflow.