add cors domains parameter #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timogoebel
force-pushed
the
feature_cors
branch
from
e9abf3d to
129cbd6
Compare
ekohl
reviewed
Feb 23, 2019
| @@ -311,6 +313,7 @@ | |||
| Stdlib::Port $dynflow_pool_size = $::foreman::params::dynflow_pool_size, | |||
| String $jobs_service = $::foreman::params::jobs_service, | |||
| Boolean $hsts_enabled = $::foreman::params::hsts_enabled, | |||
| Array[Stdlib::HTTPUrl] $cors_domains = $::foreman::params::cors_domains, | |||
There was a problem hiding this comment.
Tests fail now with unknown data type Stdlib::Httpurl.
There was a problem hiding this comment.
I went with https://github.com/puppetlabs/puppetlabs-stdlib#stdlibhttpurl but that's not what's actually in the code :( puppetlabs/puppetlabs-stdlib#1001 should fix that.
timogoebel
force-pushed
the
feature_cors
branch
from
129cbd6 to
4de9f71
Compare
|
@ekohl: Updated. |
ekohl
approved these changes
Feb 23, 2019
timogoebel
force-pushed
the
feature_cors
branch
from
4de9f71 to
1d1b181
Compare
|
Reverted the |
ekohl
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to support: theforeman/foreman#6467