Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for Amazon Linux #590

Merged
merged 1 commit into from
Apr 27, 2018
Merged

adding support for Amazon Linux #590

merged 1 commit into from
Apr 27, 2018

Conversation

RobReus
Copy link

@RobReus RobReus commented Apr 19, 2018

This has been tested on the latest Amazon Linux AMI in agent mode.

Fixes:
Error: /Stage[main]/Puppet::Agent::Service::Systemd/Service[puppet-run.timer]: Provider systemd is not functional on this host

I have added "2017" to the regex of $agent_restart_command and $unavailable_runmodes. Without it, the code will try to stop the systemd timer which will fail because systemd is not being used on Amazon Linux (yet).

Copy link
Contributor

@mmoll mmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look legit, but what willen happen 2018? ;)

@RobReus
Copy link
Author

RobReus commented Apr 19, 2018

@mmoll so far there's no 2018 version yet. When it comes out, we'll just adjust the regex to: /^(2|5|6|201(7|8))$/. Ain't it a beauty :P

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also a chance 2018 might be based on EL7 so I'm fine with doing this.

@ekohl ekohl merged commit ee01cff into theforeman:master Apr 27, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants