Refactor testing and use data types in private classes #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With rspec-puppet you're not supposed to test individual classes that should be private. This also makes it more efficient because we had quite a few duplicated cases.
By enforcing it a boolean we can use a simple if/else instead of a case statement. We can also use pick() to remove another case statement.
ekohl
force-pushed
the
refactor-testing
branch
from
bf04d26
to
b704527
Compare
|
merged, bedankt @ekohl! |
ekohl
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With rspec-puppet you're not supposed to test individual classes that should be private. This also makes it more efficient because we had quite a few duplicated cases.
By enforcing $enabled a boolean we can use a simple if/else instead of a case statement. We can also use pick() to remove another case statement.
I'll also get to the server side but it might be easier to remove passenger support first.