Refactor puppetserver spec testing #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
refactor-puppetserver-spec-testing
branch
from
46112fc
to
c76955c
Compare
ekohl
force-pushed
the
refactor-puppetserver-spec-testing
branch
from
c76955c
to
fa12a9e
Compare
|
@mmoll the centos 6 acceptance test has become unstable but I think that doesn't block this PR. |
mmoll
reviewed
Nov 2, 2018
|
on small question, 👍 otherwise |
This uses params inheritance for much cleaner tests. We also test via the main class and remove a lot of overrides that aren't needed.
ekohl
force-pushed
the
refactor-puppetserver-spec-testing
branch
from
fa12a9e
to
52397d3
Compare
|
merged, bedankt @ekohl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation of dropping support for puppetserver < 2.7