Modulesync: use voxpupuli helper gems #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
ekohl
force-pushed
the
voxpupuli-helpers
branch
2 times, most recently
from
25c33c6
to
8128cf5
Compare
ekohl
commented
Apr 13, 2020
|
please rebase :) |
ekohl
force-pushed
the
voxpupuli-helpers
branch
2 times, most recently
from
643e3a7
to
46f4128
Compare
ekohl
commented
Apr 13, 2020
manifests/params.pp
Outdated
| @@ -308,7 +308,7 @@ | |||
| # it reports its $osreleasemajor as 2, not 6. | |||
| # thats why we're matching for '2' in both parts | |||
| # Amazon Linux is like RHEL6 but reports its osreleasemajor as 2017 or 2018. | |||
| $osreleasemajor = regsubst($::operatingsystemrelease, '^(\d+)\..*$', '\1') # workaround for the possibly missing operatingsystemmajrelease | |||
| $osreleasemajor = regsubst($facts['os']['release']['full'], '^(\d+)\..*$', '\1') # workaround for the possibly missing operatingsystemmajrelease | |||
There was a problem hiding this comment.
I'm not sure about this, #694 was intended to solve it in a cleaner way.
ekohl
force-pushed
the
voxpupuli-helpers
branch
from
46f4128
to
3f6db5f
Compare
|
merged, bedankt @ekohl! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.