Allow camptocamp/systemd 3.x + use it for timers #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…md"" This reverts commit 904e51b. Initially it was reverted since it led to a dependency cycle in the Foreman installer. This was caused by a systemctl daemon-reload. Since this was a bit of an edge case and not all users will hit this, it's reinstated. The cyclic dependency can also be mitigated by using camptocamp/systemd 3.x which no longer performs the exec. This only works on Puppet 6.1 or newer though.
|
theforeman/puppet-pulpcore#198 & theforeman/puppet-foreman#956 are the other 2 modules that need to be merged for the installer to be able to use 3.x. |
ehelms
approved these changes
May 26, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows camptocamp/systemd 3.x. Additionally, it goes back to using systemd::timer now that the cyclic dependency can no longer happen.