Fixes #30857 - Merge puppet_proxy_puppet_api into mod #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
30857-merge-puppet-provider
branch
2 times, most recently
from
1970ac3
to
5ea790a
Compare
In 7e7015a the legacy provider was dropped. Since then, there is only one provider. The provider code was kept since it didn't need any changes to configuration files. However, having a module with just a single provider is complex. Both from a code perspective and as an admin. The implications are that the puppet.yaml and puppet_proxy_puppet_api.yaml files are merged (after being split in df0fc72). This means installer and manual updates are needed to reflect this.
ekohl
force-pushed
the
30857-merge-puppet-provider
branch
from
5ea790a
to
efe845c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 7e7015a the legacy provider was dropped. Since then, there is only one provider. The provider code was kept since it didn't need any changes to configuration files. However, having a module with just a single provider is complex. Both from a code perspective and as an admin.
The implications are that the puppet.yaml and puppet_proxy_puppet_api.yaml files are merged (after being split in df0fc72). This means installer and manual updates are needed to reflect this.
For now it's a draft since I didn't do a lot of testing on this. The major open question is migration of the config files. Right now it just drops the automated migration that splits it, but doesn't have a migration to merge them again. Reviews, thoughts and opinions are welcome though.