-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #35270 - Enable boot image download #837
base: develop
Are you sure you want to change the base?
Fixes #35270 - Enable boot image download #837
Conversation
1dcf666
to
5abea3c
Compare
5abea3c
to
9fdcb20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also expose this as a capability. In https://theforeman.org/2019/04/smart-proxy-capabilities-explained.html I've explained this, but this allows the Foreman side to know if the API is supported. You could even look up the presence of 7z
and only present the capability if it's present. That's another way of dealing with it.
Of course the Foreman side also needs to be modified to respect this.
9fdcb20
to
3a4bdf8
Compare
3a4bdf8
to
83d6c14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments about the command task. Perhaps ArchiveExtract
shouldn't call super
at all in start
but rather implement its own logic.
83d6c14
to
3a40fce
Compare
I had a look at your comment and I think it makes totally sense to have such a |
4ec8d4d
to
0f04cee
Compare
0f04cee
to
6aa3f2a
Compare
7a0027a
to
4f38afe
Compare
02d6874
to
691f12c
Compare
691f12c
to
45c6d78
Compare
@ekohl coming back to this. I've added tests for the Moreover, I'd like to know whether we could also trigger the |
45c6d78
to
7713fbc
Compare
7713fbc
to
0c50d94
Compare
2fa7469
to
a4fddf8
Compare
@ekohl tests are green. The
What do you think about it? Can we continue with the foreman-side of this feature? |
@ekohl I've also added PRs for |
a4fddf8
to
4e15e9c
Compare
4e15e9c
to
25b60a3
Compare
25b60a3
to
3b7ab39
Compare
* Implement fetch and extract system image * Implement class for file extraction with isoinfo * Add capability for archive extraction * Separate logging and file writing tasks * Add additional API endpoint /tftp/system_image/ Co-Authored-By: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
3b7ab39
to
a230b04
Compare
@ekohl do you know why there are no test results? Did I forgot anything, maybe? |
Manage ISO images as Installation media. Refers to this PR.
Includes the following changes:
ToDo: Add tests.