-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add matrix.json specifying our Ruby versions #883
base: develop
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,3 @@ | |||
{ | |||
"ruby": ["2.7", "3.0"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jenkins also runs 3.1, should we add that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given we decided this file only indicates "minimal tested versions", I think 3.1 doesn't (yet) belong in here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to derive this from a place we already have, the gemspec:
smart-proxy/smart_proxy.gemspec
Line 15 in e8fe59f
s.required_ruby_version = '>= 2.7' |
It may be harder to reuse it in plugins, but it avoids duplication. Remember that the Smart Proxy can actually be a real gem.
I'd still be in favor of using our gem testing workflow. It's simpler and testing of Smart Proxy & plugins is usually fast anyway. We'll automatically test on Ruby 3.2 as well, which allows us to move forward faster. I just need to update https://github.com/ekohl/ruby-version/ to also test Ruby 3.3 (which helps with EL 10). Shall we close this? |
No description provided.