Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add matrix.json specifying our Ruby versions #883

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Jan 5, 2024

No description provided.

@@ -0,0 +1,3 @@
{
"ruby": ["2.7", "3.0"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jenkins also runs 3.1, should we add that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given we decided this file only indicates "minimal tested versions", I think 3.1 doesn't (yet) belong in here

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to derive this from a place we already have, the gemspec:

s.required_ruby_version = '>= 2.7'

It may be harder to reuse it in plugins, but it avoids duplication. Remember that the Smart Proxy can actually be a real gem.

@ekohl
Copy link
Member

ekohl commented Jul 8, 2024

I'd still be in favor of using our gem testing workflow. It's simpler and testing of Smart Proxy & plugins is usually fast anyway. We'll automatically test on Ruby 3.2 as well, which allows us to move forward faster. I just need to update https://github.com/ekohl/ruby-version/ to also test Ruby 3.3 (which helps with EL 10).

Shall we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants