Fixes #37319 - Allow setting IDs for outputs #135
Merged
+102
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ekohl
reviewed
Jul 17, 2024
| @@ -37,18 +37,20 @@ def humanize | |||
| raw_outputs.map { |output| output['output'] }.join("\n") | |||
| end | |||
|
|
|||
| def add_exception(context, exception, timestamp = Time.now.getlocal) | |||
| add_output(context + ": #{exception.class} - #{exception.message}", 'debug', timestamp) | |||
| def add_exception(context, exception, timestamp: Time.now.getlocal, id: nil) | |||
There was a problem hiding this comment.
Isn't this an API change?
def add_exception(context, exception, timestamp = 'now')
puts timestamp
end
def add_exception_new(context, exception, timestamp: 'now')
puts timestamp
end
add_exception('a', 'b')
add_exception('a', 'b', 'explicit')
add_exception_new('a', 'b')
add_exception_new('a', 'b', 'explicit')$ ruby test2.rb
now
explicit
now
test2.rb:5:in `add_exception_new': wrong number of arguments (given 3, expected 2) (ArgumentError)
from test2.rb:13:in `<main>'Or do you accept it since it only appears to be used internally.
There was a problem hiding this comment.
While this isn't strictly private api, none of the smart proxy plugins which depend on sp-dynflow seem to use this, so I'd be willing to let it slide.
ekohl
approved these changes
Jul 17, 2024
Comment on lines
44
to
45
| def add_output(*args, **kwargs) | ||
| add_raw_output(self.class.format_output(*args, **kwargs)) |
There was a problem hiding this comment.
Would it make sense to also just forward the arguments here?
Suggested change
| def add_output(*args, **kwargs) | |
| add_raw_output(self.class.format_output(*args, **kwargs)) | |
| def add_output(...) | |
| add_raw_output(self.class.format_output(...)) |
and switch runner output interface to be keyword based.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and switch runner output interface to be keyword based.