Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start adding docs via typedoc #659

Merged
merged 14 commits into from
Dec 4, 2020
Merged

Start adding docs via typedoc #659

merged 14 commits into from
Dec 4, 2020

Conversation

jnicklas
Copy link
Collaborator

This is a first stab at adding docs via TypeDoc.

Unfortunately this uses a frozen in time, outdated fork of TypeDoc, found here TypeStrong/typedoc#1184, because the output generated just isn't very nice, but is pretty great with this fork 🤷‍♂️

It seems like some other projects are also doing this. Not sure what this says about TypeDoc.

It also takes some finagling to get docs for interactors to display in a comprehensible way.

Screenshot 2020-10-27 at 14 41 38

Screenshot 2020-10-27 at 14 41 46

@jnicklas jnicklas requested a review from cowboyd October 27, 2020 13:42
@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2020

⚠️ No Changeset found

Latest commit: a1c4df8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2020

The preview packages of this pull request have been published.
Click on the following packages for instructions on how to install them:

bigtest

Install using the following command:

$ npm install bigtest@typedoc-poc

Or update your package.json file:

{
  "bigtest": "typedoc-poc"
}

@bigtest/interactor

Install using the following command:

$ npm install @bigtest/interactor@typedoc-poc

Or update your package.json file:

{
  "@bigtest/interactor": "typedoc-poc"
}

@bigtest/suite

Install using the following command:

$ npm install @bigtest/suite@typedoc-poc

Or update your package.json file:

{
  "@bigtest/suite": "typedoc-poc"
}

Generated by 🚫 dangerJS against a1c4df8

@jorgelainfiesta
Copy link
Contributor

How can I preview the docs in a browser, like what command should I run? I tried browsing TypeDoc's website but I couldn't figure it out.

@Gerrit0
Copy link

Gerrit0 commented Oct 31, 2020

Recommendation: switch to typedoc@beta, which is version 0.20.0-beta.#, and is under active development. I need to update the linked PR to point people towards that...

@taras
Copy link
Member

taras commented Oct 31, 2020

Thank you @Gerrit0!

@jnicklas
Copy link
Collaborator Author

jnicklas commented Nov 2, 2020

Thanks @Gerrit0, I upgraded to the beta and it works perfectly.

@jorgelainfiesta I don't have any good way of putting these docs online right now. You can run yarn typedoc in packages/bigtest, and it will output the generated docs into packages/bigtest/docs.

@jnicklas
Copy link
Collaborator Author

jnicklas commented Nov 2, 2020

We'll probably want to add a deploy hook for these!

@jnicklas
Copy link
Collaborator Author

jnicklas commented Dec 2, 2020

This is by no means done, but I think it's good enough now where we can actually merge this and start working on integrating these docs into the website.

Docs can be generated for the @bigtest/suite, @bigtest/interactor and bigtest packages, by running yarn typedoc in their respective directories.

Comment on lines +1 to +3
# BigTest

This is cool stuff {@link createInteractor}, yeah!
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is just a placeholder, we'll want to expand this to link to the most relevant parts of the documentation.

Doing this allows us to link stuff from the API docs and have a better
introduction. We'll have getting started guides separate anyway.
This makes it easier to work on documentation for each package
individually.
@jnicklas jnicklas merged commit b834d85 into v0 Dec 4, 2020
@jnicklas jnicklas deleted the typedoc-poc branch December 4, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants