Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme to use printSchemaWithDirectives instead of printSchema #165

Merged
merged 1 commit into from
Dec 17, 2022

Conversation

wKich
Copy link
Member

@wKich wKich commented Nov 23, 2022

Motivation

printSchema from graphql outputs schema without directives, as a result, if you use your own directives and custom codegen plugin which utilize those directives, the output schema will not have directives graphql/graphql-js#869

Approach

Update recommendation to use printSchemaWithDirectives from graphql-tools instead

@wKich wKich requested review from cowboyd and taras November 23, 2022 08:50
@changeset-bot
Copy link

changeset-bot bot commented Nov 23, 2022

🦋 Changeset detected

Latest commit: f35c094

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@frontside/backstage-plugin-graphql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wKich wKich force-pushed the dl/update-readme-print-schema branch from 54a0c39 to f35c094 Compare November 23, 2022 08:50
@frontsidejack
Copy link
Member

frontsidejack commented Nov 23, 2022

📣 NOTIFICATION
You are receiving this message because we did not publish any packages.

Generated by @thefrontside/actions Frontside

@wKich wKich merged commit 01a9c3e into main Dec 17, 2022
@wKich wKich deleted the dl/update-readme-print-schema branch December 17, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants