Agora broadcasting #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That would be great! TY! |
nate-thegrate
force-pushed
the
agora_broadcasting
branch
from
b3c7776
to
1a31236
Compare
nate-thegrate
force-pushed
the
agora_broadcasting
branch
from
ac21bd7
to
0275c9f
Compare
There was a problem hiding this comment.
@ChaAbby btw, let me know if I can help out with your checkout of this branch—I know that having someone else force-push to it can make things sort of wonky
Comment on lines
+204
to
+206
| if (isAudioEnabled != isAudioEnabled) 'isAudioEnabled': isAudioEnabled, | ||
| if (isVideoEnabled != isVideoEnabled) 'isVideoEnabled': isVideoEnabled, | ||
| if (view != view) 'view' : view, |
There was a problem hiding this comment.
A couple of questions here:
- It seems as though
if (x != x)will always return false, do you know what the intended behavior is here? - I noticed that
viewhas a theWidget?type, and I'm not exactly sure how we're intending to represent it in JSON format.
(I also haven't seen anywhere that sets a value forview.)
Comment on lines
+103
to
+104
| bool? isAudioEnabled; | ||
| bool? isVideoEnabled; |
There was a problem hiding this comment.
Unfortunately, adding these non-final values to an @immutable class is triggering some static analysis problems.
In my opinion, it would make the most sense to store these values in LocalStorage. What are your thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR.
Directors can start live streams and participants can join the channel.
I am currently not seeing the video on my end -- with the app simulator on my mac it is not compatible with the laptop camera, so not sure if I haven't gotten it set up correctly or its not showing up because of that.