Add files via upload #76
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi Felicia! Thanks for your patience, and apologies for the confusion—I believe the Notion task you were assigned was for allowing admins to delete user accounts, whereas this PR seems to involve a user deleting their own account.
Thanks again for the continued contributions, despite how the vastly different time zones can make it difficult to sync up. Since #75 is set up to be editing the correct file, would you be good on closing this pull request and focusing on that one?
Comment on lines
-96
to
+102
| title: const Text('close account'), | ||
| onTap: () => navigator.showDialog(const CloseAccount()), | ||
| title: const Text('Close Account'), | ||
| onTap: () => showDialog( | ||
| context: context, | ||
| builder: (context) => const DeleteAccountDialog(), | ||
| ), |
There was a problem hiding this comment.
Oh dang, looks like with this change, we now have delete_account.dart and close_account.dart which are set up to do the exact same thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//ability to remove accounts