docker full: fixed gpg typo (ubuntu 18.04)

[avelino]

It is some kind of IPV6-related issue to ipv4 instead.

refs:

• Docker full upgrate to Ubuntu 18.04 #136 (comment)
• GPG Keyserver for gosu key intermittently fails jacobalberty/unifi-docker#64 (comment)

thanks @marcdumais-work

[marcdumais-work]

Hi @avelino

Looking good so far.

There is a second block, just a bit lower, that has the same issue:
https://github.com/theia-ide/theia-apps/pull/140/files#diff-248e1209aca6bd97b133a2985a672563L59

[marcdumais-work]

Thanks @avelino - it seems to work better now, at least on my laptop.

Could you please squash these two commits together and sign (git commit -s) the resulting commit?

[avelino]

@marcdumais-work done
You could do squash on merge the GitHub interface
https://help.github.com/en/articles/merging-a-pull-request#merging-a-pull-request-on-github

[marcdumais-work]

@avelino
Thanks for squashing the commits.

You could do squash on merge the GitHub interface

We tend to prefer the "rebase and merge" way, but have not been 100% consistent.

[marcdumais-work]

@avelino I think the commit message could better describe the change. Can you update it? I suggest something like "[full] Optimized fetching GPG keys for node/yarn installs".

And please also sign the commit:
git commit --amend -s

Thanks!

[avelino]

@avelino I think the commit message could better describe the change. Can you update it? I suggest something like "[full] Optimized fetching GPG keys for node/yarn installs".

And please also sign the commit:
git commit --amend -s

Thanks!

@marcdumais-work done

[marcdumais-work]

@avelino Thanks for signing the commit. However I still see the original commit message:

Can you update that?

[avelino]

I (Avelino) do not see problem in having to change both my contribution. It is important to have this action lead contributors away from the project.

Sorry for telling the truth

[marcdumais-work]

@avelino I think it's important to have a commit message that correctly reflects what was changed. Thanks for making the update.

[marcdumais-work]

LGTM, thanks @avelino