In some cases, rmw has unpredictable behavior when restoring from a removable device

[andy5995]

How I reproduced this error:

1. Removed files from /mnt/flash (where flash is the topdir) using the "move to trash" option from the thunar file manager in xfce

2. Attempted to restore with rmw produced this error:

$ rmw -vz *
config file: /home/andy/.config/rmwrc
most recent list (mrl file): /home/andy/.local/share/rmw/mrl
Duplicate filename at destination - appending time string...
  :error: A NULL string was passed to bufchk. That should not happen.
Please report this bug to the rmw developers.

Looking at the info files created when I used "move to trash", I saw that the absolute path was not used for the "Path" key. Reading the Freedesktop trash spec, I saw that is correct

The key “Path” contains the original location of the file/directory, as either an absolute pathname (starting with the slash character “/”) or a relative pathname (starting with any other character). A relative pathname is to be from the directory in which the trash directory resides (for example, from $XDG_DATA_HOME for the “home trash” directory); it MUST not include a “..” directory, and for files not “under” that directory, absolute pathnames must be used. The system SHOULD support absolute pathnames only in the “home trash” directory, not in the directories under $topdir.

rmw was designed (incorrectly) to always expect an absolute path and parse the Path key accordingly

And due to the nature of this problem, other errors while trying to restore with rmw include files getting "restored" to the $trash/files folder in some cases (e.g. if rmw -z is used from the $trash/files directory, the relative path from its corresponding trashinfo file is used).

[andy5995]

I'm picking away at this a little bit almost every day. Almost done; mostly just working on tests. Branch patch/iss-299.

Due to the nature of this bug, once this issue is closed, a release should follow soon after.