Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runInSync is not running tests in sync #836

Closed
pottedmeat opened this issue Nov 7, 2017 · 1 comment
Closed

runInSync is not running tests in sync #836

pottedmeat opened this issue Nov 7, 2017 · 1 comment
Labels
bug Something that's not working as intended

Comments

@pottedmeat
Copy link

No description provided.

@jason0x43 jason0x43 added the bug Something that's not working as intended label Nov 7, 2017
@jason0x43
Copy link
Member

When runInSync is enabled and a Promise is returned in an event handler, Intern should wait for the Promise to resolve before continuing execution. This should work both locally and in remote executors. This behavior appears to be broken at least for remote executors (like, if a Promise is returned in a testEnd event handler on the host intern, remote executors aren't waiting for the event handler to finish before running more tests).

jason0x43 added a commit that referenced this issue Nov 10, 2017
@jason0x43
Fix runInSync implementation
f4d1fb7 
- Ensure runInSync is passed to remote
- Fix shouldWait logic in Server (it was backwards)

resolves #836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something that's not working as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pottedmeat @jason0x43