Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SuiteLifecycleFunction shouldn't require a PromiseLike<void> #845

Closed
jason0x43 opened this issue Nov 21, 2017 · 0 comments
Closed

SuiteLifecycleFunction shouldn't require a PromiseLike<void> #845

jason0x43 opened this issue Nov 21, 2017 · 0 comments

Comments

@jason0x43
Copy link
Member

Currently the SuiteLifecycleFunction interface expects its callback to return void | PromiseLike<void>. However, this can cause problems; for example, it may sometimes be convenient to return a PromiseLike<Element> in a functional test (where finding an element acts as an assertion of its existence).

Instead, SuiteLifecycleFunction should require void | PromiseLike<any>.
@jason0x43 jason0x43 mentioned this issue Nov 21, 2017
Open
jason0x43 added a commit that referenced this issue Dec 5, 2017
@jason0x43
Relax callback typings in Suite API
67b4721 
SuiteLifecycleFunction and TestLifecycleFunction callbacks should be
typed as `void | PromiseLike<any>` rather than `void |
PromiseLike<void>` since Suite doesn't really care about the *type* of a
PromiseLike value, just when it resolves.

resolves #845
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jason0x43