Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SystemJS loader script is broken in Node #866

Closed
jason0x43 opened this issue Jan 5, 2018 · 0 comments
Closed

SystemJS loader script is broken in Node #866

jason0x43 opened this issue Jan 5, 2018 · 0 comments
Labels
bug Something that's not working as intended

Comments

@jason0x43
Copy link
Member

Expected behavior

Loading tests using SystemJS with the "systemjs" loader script in Node should work.

Current behavior

An error is thrown:

TypeError: globalObj.require is not a function
  at <src\loaders\systemjs.ts:21:29>
  at Node.BaseExecutor.registerLoader  <src\lib\executors\Executor.ts:496:37>
  at Object.<anonymous>  <src\loaders\systemjs.ts:9:7>

Environment

Intern version: 4.1.4

Additional information

See https://gitter.im/theintern/intern?at=5a4e8eb75355812e5751941a
@jason0x43 jason0x43 added needs-verification Needs to be verified bug Something that's not working as intended and removed needs-verification Needs to be verified labels Jan 5, 2018
@jason0x43 jason0x43 changed the title SystemJS loader script may be broken in Node SystemJS loader script is broken in Node Jan 8, 2018
jason0x43 added a commit that referenced this issue Jan 8, 2018
@jason0x43
Use Node require properly in systemjs loader
b7aaa83 
Don't assume it's on the global object; this will only be the case for
tests.

fixes #866
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something that's not working as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jason0x43