Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make loader paths configurable for built-in loader scripts #872

Open
jason0x43 opened this issue Jan 15, 2018 · 1 comment
Open

Make loader paths configurable for built-in loader scripts #872

jason0x43 opened this issue Jan 15, 2018 · 1 comment
Assignees
@msssk
Labels
effort-low Should be pretty quick enhancement A new or improved feature priority-high Most important

Comments

@jason0x43
Copy link
Member

The paths to the loaders (Dojo, SystemJS, ...) are hardcoded in the loader scripts in Intern 4. Consider making them configurable with a loader option.
@jason0x43 jason0x43 added the enhancement A new or improved feature label Jan 15, 2018
@jason0x43
Copy link
Member Author

Ideally any Intern-specific metadata would be separate from the loader options, but that would involved changing the registerLoader interface. Probably the best way to go here is to support an internLoaderPath option for the loader scripts. This option would be filtered out of the options that were passed to the loader itself.

@jason0x43 jason0x43 added effort-low Should be pretty quick priority-low We'll get to this eventually labels Jan 29, 2020
@jason0x43 jason0x43 added priority-high Most important and removed priority-low We'll get to this eventually labels May 28, 2020
@msssk msssk mentioned this issue May 28, 2020
Merged
jason0x43 pushed a commit that referenced this issue Jun 3, 2020
@msssk
feat: add support for 'internLoaderPath' in loader options
9024f8b 
resolves #872
jason0x43 pushed a commit that referenced this issue Jun 4, 2020
@msssk @jason0x43
feat: add support for 'internLoaderPath' in loader options
9b3fd5d 
resolves #872
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msssk msssk

Labels
effort-low Should be pretty quick enhancement A new or improved feature priority-high Most important
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@msssk @jason0x43