Do not run suite lifecycle methods when all descendant tests are skipped

[jonnycornwell]

• Add tests to ensure suite lifecycle functions do not run if all tests are skipped
• Evaluate grep up front rather than when the tests are executed

In our functional end-to-end tests we have had to write our own grep due to this, some of our before functions have substantial setup by navigating the app. Also mentioned in comment #950 (comment).

I have gone round the houses a bit with regards to this PR and think the dust has now settled, I was getting caught out by the fact grep is set on the rootSuite after instantiation, in that case it needs to process all the children recursively.

With regards to #950 (comment), I believe the tests should be added and skipped rather than just excluded.

p.s. This PR will have a merge conflict with my other PR (#955) relating to the type information for LifecycleMethod.

[codecov-io]

Codecov Report

Merging #961 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #961      +/-   ##
==========================================
+ Coverage   92.64%   92.67%   +0.03%     
==========================================
  Files          58       58              
  Lines        4582     4601      +19     
  Branches      997     1000       +3     
==========================================
+ Hits         4245     4264      +19     
  Misses        337      337

Impacted Files	Coverage Δ
src/lib/Suite.ts	96.67% <100%> (+0.22%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b99fe83...3a00d61. Read the comment docs.

[jonnycornwell]

Just thought of a slight edge case related to my changes and have fixed accordingly

[jonnycornwell]

Upon investigating #962, I noticed that there was a race condition in the name being set after the grep following the other changes in this PR.

I have now added a failing tests for this and also a fix in 3a00d61

intern/src/lib/executors/Executor.ts

Lines 798 to 799 in 6a93567

	this._rootSuite.grep = grep;
	this._rootSuite.name = name;

.

I am 99% sure I have no more changes or PRs to raise and no more changes to make to this PR!

[jason0x43]

Ooo, this will be handy. I'll try to get to this in the relatively near future.

[jonnycornwell]

I am glad I left myself 1% wiggle room in my confidence. I have rolled this PR out throughout our builds and have found an issue with running unit tests via the Node runner. I haven't come across any issues when running functionalSuites or tests in the browser with the Html reporter.

Just trying to find the appropriate fix and will add it to this PR once I get a clean run through our builds