Filter out Stargate/coordinator nodes from calls to get live nodes or list tokens #1433
+56
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adejanovski
force-pushed
the
fix-untranslated-host
branch
6 times, most recently
from
d851b0a
to
6e4bf68
Compare
… list tokens. The http management implementation uses endpoint states for listing nodes and tokens, unlike JMX, which also contains Stargate nodes. This breaks some calls which expect the Stargate nodes to behave like standard Cassandra nodes. This commit filters out the endpoint state entries that don't have tokens to make sure Stargate nodes aren't accounted for when they shouldn't be.
adejanovski
force-pushed
the
fix-untranslated-host
branch
from
6e4bf68
to
1d13baf
Compare
adejanovski
changed the title
emerkle826
approved these changes
Oct 23, 2023
Comment on lines
411
to
413
| if (states.containsKey("IS_ALIVE") | ||
| && Boolean.parseBoolean(states.get("IS_ALIVE")) | ||
| && !isCoordinatorNode(states)) { |
There was a problem hiding this comment.
suggestion:
I think it would be a small optimization to check if it's a coordinator node first as the states should almost always have an "IS_ALIVE" key. For coordinator-only nodes(i.e. Stargate), changing the order of the checks here will reduce the number of map reads I think.
Suggested change
| if (states.containsKey("IS_ALIVE") | |
| && Boolean.parseBoolean(states.get("IS_ALIVE")) | |
| && !isCoordinatorNode(states)) { | |
| if (!isCoordinatorNode(states) | |
| && states.containsKey("IS_ALIVE") | |
| && Boolean.parseBoolean(states.get("IS_ALIVE"))) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1432