Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dotenv dependency to the build image #1467

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Add dotenv dependency to the build image #1467

merged 1 commit into from
Feb 14, 2024

Conversation

adejanovski
Copy link
Contributor

@adejanovski adejanovski commented Feb 13, 2024 •
edited
Loading

Fixes #1468

@adejanovski adejanovski marked this pull request as ready for review February 13, 2024 12:08
olim7t
olim7t approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@olim7t olim7t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked locally with:

mvn package -DskipTests && docker-compose -f ./src/packaging/docker-build/docker-compose.yml build

@adejanovski adejanovski merged commit c290720 into master Feb 14, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olim7t olim7t olim7t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Builds are broken due to a missing ruby dependency
2 participants
@adejanovski @olim7t