Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dropwizard.version to 2.1.0 #1481

Merged
merged 7 commits into from
Mar 23, 2024
Merged

Upgrade dropwizard.version to 2.1.0 #1481

merged 7 commits into from
Mar 23, 2024

Conversation

FieteO
Copy link
Contributor

@FieteO FieteO commented Mar 18, 2024 •
edited
Loading

Bump dropwizard.version to 2.1.12. Fixes #1462

@FieteO FieteO marked this pull request as draft March 19, 2024 00:00
@FieteO
Copy link
Contributor Author

FieteO commented Mar 19, 2024

@adejanovski It looks like the setup of the tmate session is timing out. Is this related to my changes, or some flakiness in the Actions workflow?

@adejanovski
Copy link
Contributor

@adejanovski It looks like the setup of the tmate session is timing out. Is this related to my changes, or some flakiness in the Actions workflow?

tmate stays open for 30 minutes and then times out to allow the workflow to end.
Nothing misbehaving here, the core issue is in the breakage that the dropwizard upgrade created.

@FieteO
Copy link
Contributor Author

FieteO commented Mar 19, 2024 •
edited
Loading

Ah, I didn't see the failing test step before. Is there any way of running these (integration?) tests locally?

I tried to invoke TEST_TYPE=ccm ./.github/scripts/run-tests.sh but that fails with not finding the ccm executable.
I guess I could install that, but it would likely still fail right?

@FieteO FieteO force-pushed the update-dropwizard-version branch from dbb81a4 to fc76b9b Compare March 20, 2024 09:13
@FieteO
do not use dropwizard provided objectmapper since it is not throwing …
32927e0 
…the same exception that is thrown in a test case
@FieteO FieteO marked this pull request as ready for review March 21, 2024 22:47
@FieteO
Copy link
Contributor Author

FieteO commented Mar 21, 2024

2.1.0 seems to work now. Shall I try to bump it to the last patch version 2.1.12 @adejanovski ?

@adejanovski
Copy link
Contributor

2.1.0 seems to work now. Shall I try to bump it to the last patch version 2.1.12 @adejanovski ?

That seems like a good idea. Thanks for handling this @FieteO !

adejanovski
adejanovski requested changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@adejanovski adejanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

Just one leftover comment to remove and we're good to go.

src/server/src/main/java/io/cassandrareaper/management/ClusterFacade.java Outdated Show resolved Hide resolved
@FieteO FieteO requested a review from adejanovski March 23, 2024 13:59
adejanovski
adejanovski approved these changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@adejanovski adejanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @FieteO 🙏

@adejanovski adejanovski merged commit 4fad46a into thelastpickle:master Mar 23, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adejanovski adejanovski adejanovski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upgrade dropwizard.version 2.1.0 or higher to fix CVEs
2 participants
@FieteO @adejanovski