-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refine logging #3347
Merged
Merged
feat: refine logging #3347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gary02
force-pushed
the
feat/refine-logging
branch
from
May 12, 2023 09:25
ae75462
to
a38b109
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #3347 +/- ##
===========================================
+ Coverage 54.93% 54.95% +0.02%
===========================================
Files 488 489 +1
Lines 12044 12106 +62
Branches 2693 2692 -1
===========================================
+ Hits 6616 6653 +37
- Misses 4992 5012 +20
- Partials 436 441 +5
☔ View full report in Codecov by Sentry. |
… as logger dont use Sentry now
Closed
robertu7
approved these changes
May 15, 2023
robertu7
reviewed
May 15, 2023
robertu7
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
console.log
like lazy formatingutil.debuglog
like envs flagwarn
in CI