Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refine logging #3347

Merged
merged 15 commits into from
May 16, 2023
Merged

feat: refine logging #3347

merged 15 commits into from
May 16, 2023

Conversation

gary02
Copy link
Contributor

@gary02 gary02 commented May 12, 2023

  • impl logger
    • console.log like lazy formating
    • util.debuglog like envs flag
    • requestId context
  • refine logging
    • set logging level to warn in CI
    • refine exist logs and add new logs

@gary02 gary02 requested a review from a team as a code owner May 12, 2023 06:48
@gary02 gary02 force-pushed the feat/refine-logging branch from ae75462 to a38b109 Compare May 12, 2023 09:25
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch coverage: 66.34% and project coverage change: +0.02 🎉

Comparison is base (746f5fa) 54.93% compared to head (f190c9f) 54.95%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3347      +/-   ##
===========================================
+ Coverage    54.93%   54.95%   +0.02%     
===========================================
  Files          488      489       +1     
  Lines        12044    12106      +62     
  Branches      2693     2692       -1     
===========================================
+ Hits          6616     6653      +37     
- Misses        4992     5012      +20     
- Partials       436      441       +5     
Impacted Files Coverage Δ
src/mutations/user/updateUserRole.ts 37.50% <ø> (ø)
src/connectors/articleService.ts 31.19% <11.76%> (ø)
src/connectors/cloudflare/index.ts 36.95% <33.33%> (+2.86%) ⬆️
src/connectors/queue/revision.ts 23.85% <33.33%> (+3.34%) ⬆️
src/connectors/stripe/index.ts 34.74% <33.33%> (-0.84%) ⬇️
src/connectors/likecoin/index.ts 20.35% <40.00%> (-11.77%) ⬇️
src/connectors/aws/index.ts 38.46% <46.15%> (+0.81%) ⬆️
src/connectors/gcp/index.ts 32.69% <50.00%> (+1.31%) ⬆️
src/connectors/tagService.ts 47.27% <50.00%> (ø)
src/mutations/article/readArticle.ts 33.33% <50.00%> (+3.92%) ⬆️
... and 40 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gary02 gary02 changed the title WIP: refine logging feat: refine logging May 15, 2023
@gary02 gary02 linked an issue May 15, 2023 that may be closed by this pull request
db/globalTestSetup.js Show resolved Hide resolved
src/common/logger.ts Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@gary02 gary02 merged commit bafdee1 into develop May 16, 2023
@delete-merged-branch delete-merged-branch bot deleted the feat/refine-logging branch May 16, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine backend logging
2 participants