Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(taglist): update text hashtag symbol to actual icon #4419

Closed
wants to merge 5 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(feed-test): flaky unit tests when multiple text elements are present
  • Loading branch information
byhow committed May 21, 2024
commit 2c16f838ea896978c79927b13240b48e24b1c45d
2 changes: 1 addition & 1 deletion src/components/TagDigest/Feed/Feed.test.tsx
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@ describe('<TagDigest.Feed>', () => {
$digest.click()
expect(mockRouter.asPath).toContain(MOCK_TAG.slug)

const $name = screen.getByText(MOCK_TAG.content)
const $name = screen.getAllByText(MOCK_TAG.content)[0] // duplicated items in the mock
expect($name).toBeInTheDocument()

const $articleCount = screen.getByText(MOCK_TAG.numArticles)
4 changes: 0 additions & 4 deletions src/components/TagDigest/Feed/index.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { VisuallyHidden } from '@reach/visually-hidden'
import gql from 'graphql-tag'
import Link from 'next/link'

@@ -120,9 +119,6 @@ const Feed = ({ tag, ...cardProps }: TagDigestFeedProps) => {
>
<Link {...path} legacyBehavior>
<a>
<VisuallyHidden>
<span>{tag.content}</span>
</VisuallyHidden>
<ResponsiveImage
url={tag.cover || IMAGE_TAG_COVER.src}
width={144}
Loading