feat(taglist): update text hashtag symbol to actual icon #4433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
robertu7
suggested changes
May 22, 2024
robertu7
suggested changes
May 22, 2024
byhow
force-pushed
the
refactor/tag-component-usage
branch
from
7d67663 to
cfcf634
Compare
byhow
force-pushed
the
refactor/tag-component-usage
branch
2 times, most recently
from
5904c0f to
774afb1
Compare
|
Here are some sample tag styles after refactoring icons into text: Feed
Article
Search
Cover Image
Draft add tag
Draft Selected Tag
|
robertu7
suggested changes
May 23, 2024
byhow
force-pushed
the
refactor/tag-component-usage
branch
from
0897d7d to
ab5c99f
Compare
byhow
force-pushed
the
refactor/tag-component-usage
branch
from
28e9293 to
cc1b6fe
Compare
|
@robertu7 All comments are addressed and ready for review again. I am not the best person when it comes to CSS so please let me know if there's any issues in the refactoring for that part. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addendum to #4419
re #4371