Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(layout): add popover for new journal entry #4516

Merged
merged 35 commits into from
Jun 11, 2024
Merged

Conversation

byhow
Copy link
Contributor

@byhow byhow commented Jun 5, 2024

re: #4487
close #4513

@byhow byhow requested a review from a team as a code owner June 5, 2024 01:38
Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
matters-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 8:23am

@robertu7 robertu7 requested review from robertu7 and wlliaml June 7, 2024 07:05
src/components/Layout/NavBar/NavBanner.tsx Outdated Show resolved Hide resolved
src/components/Layout/NavBar/NavPopover.tsx Outdated Show resolved Hide resolved
src/components/Layout/NavBar/styles.module.css Outdated Show resolved Hide resolved
src/components/Layout/NavBar/styles.module.css Outdated Show resolved Hide resolved
src/components/Layout/NavBar/styles.module.css Outdated Show resolved Hide resolved
placement="top"
onShown={hidePopperOnClick}
offset={[0, 12]} // 16px - 4px (default tippy padding)
theme="mobile"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be shadow border instead of grey border

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the box shadow mimic the same as dropdown. If you are referring to the top border, I am not sure how would that work with the current state of CSS. I tried to use the exact same class here:
https://github.com/thematters/matters-web/pull/4516/files#diff-86d58c4f4ea93cb30bc1b5aed1e1d8b3fa26105d3f3568973c50b2aa2e3f581fL149

@byhow byhow merged commit f031e7e into feat/journal Jun 11, 2024
5 of 6 checks passed
@byhow byhow deleted the feat/activity-modal branch June 11, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants