Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notice): correct moment notices #4683

Merged
merged 3 commits into from
Jul 29, 2024
Merged

fix(notice): correct moment notices #4683

merged 3 commits into from
Jul 29, 2024

Conversation

robertu7
Copy link
Contributor

  • correct copy & translations;
  • correct gql fragment spread;
  • add MOCK_MOMENT_COMMENT and correct mock moment notices;
  • remove unused mock notices;
  • rename truncateTitle to truncateMomentTitle;
  • revise <NoticeMomentTitle> and make moment title inside;

resolve: #4489

@robertu7 robertu7 requested a review from a team as a code owner July 25, 2024 08:45
@vercel Vercel
Copy link

vercel bot commented Jul 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
matters-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 6:38am

@robertu7 robertu7 requested review from byhow and wlliaml July 25, 2024 08:46
@robertu7 robertu7 merged commit 780112d into feat/journal Jul 29, 2024
5 of 6 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/moment-notices branch July 29, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byhow byhow byhow approved these changes

@wlliaml wlliaml Awaiting requested review from wlliaml

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertu7 @byhow