Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor .post-eof & Siblings #759

Closed
ivan-nginx opened this issue Mar 29, 2019 · 12 comments
Closed

Refactor .post-eof & Siblings #759

ivan-nginx opened this issue Mar 29, 2019 · 12 comments

Comments

@ivan-nginx
Copy link
Member

So, in Muse and Pisces – .post-eof enabled.
In Mist – disabled and in Gemini – disabled & implemented with another way.

Originally posted by @ivan-nginx in #744

@zq1997
Copy link
Contributor

zq1997 commented Mar 30, 2019

Report a bug about it,

in recent update, many unnecessary important! is removed, but it cause the extra post-eof area under read more... button.

I'm dev - Google Chrome_009

Raincal's Blog - Google Chrome_010

Will this problem be solved in this refactor?

@1v9 1v9 added the Bug label Mar 30, 2019
@1v9
Copy link
Member

1v9 commented Mar 30, 2019

@zq-97 Confirmed, this is because #728 removed !important in hide()

@stevenjoezhang
Copy link
Contributor

stevenjoezhang commented Mar 30, 2019

@zq-97 @1v9 Will be fixed in #744, wait for this PR to be merged

@ivan-nginx
Copy link
Member Author

@zq-97 if fixed confirmed, close it please.

@zq1997
Copy link
Contributor

zq1997 commented Mar 30, 2019

@ivan-nginx Not authorized to close this issue because it's not created by me.

@ivan-nginx
Copy link
Member Author

Well, this issue actually not about that bug, but about another improvement, related to .post-eof.

Can u just confirm what your bug is already fixed?

@zq1997
Copy link
Contributor

zq1997 commented Mar 30, 2019

I saw this exsited .post-eof issue when I was going to report a bug hours ago, so I reported it here.
Anyway now it's confimed fixed.

@stevenjoezhang
Copy link
Contributor

屏幕快照 2019-04-03 下午2 25 26

Seems no issue here. They are implemented in the same way.

@ivan-nginx
Copy link
Member Author

In Gemini post separating implemented in another way. So, no need 2 another ways for post separating, need to choose only one.

@stevenjoezhang
Copy link
Contributor

I'm interested in it. But it's not related to .post-eof, right? It's hide in Gemini.

@ivan-nginx
Copy link
Member Author

It's hide in Gemini

Exactly! That's why Issue labeled «Improvement Needed», this isn't bug or feature request.

@stevenjoezhang
Copy link
Contributor

We can use Child and Sibling Selectors to make CSS more clear. Let's discuss it here: #867

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants