Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant styles #728

Merged
merged 1 commit into from
Mar 23, 2019
Merged

Remove redundant styles #728

merged 1 commit into from
Mar 23, 2019

Conversation

stevenjoezhang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: #722

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@CLAassistant
Copy link

CLAassistant commented Mar 23, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ivan-nginx
ivan-nginx approved these changes Mar 23, 2019
View reviewed changes
Copy link
Member

@ivan-nginx ivan-nginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no breaknig changes releated to Fonts pull?

@ivan-nginx ivan-nginx added this to the v7.1.0 milestone Mar 23, 2019
@stevenjoezhang
Copy link
Contributor Author

Nope, just dealing with some possible historical issues

@stevenjoezhang stevenjoezhang merged commit 8ef50b7 into theme-next:master Mar 23, 2019
@stevenjoezhang stevenjoezhang deleted the styl branch March 23, 2019 14:17
@stevenjoezhang stevenjoezhang mentioned this pull request Mar 23, 2019
Closed
3 tasks
ivan-nginx
ivan-nginx reviewed Mar 25, 2019
View reviewed changes
source/css/_common/components/sidebar/sidebar-button.styl
@@ -5,7 +5,7 @@
display: inline-block;
padding: 0 15px;
color: rgb(252, 100, 35);
border: 1px solid rgb(252, 100, 35);
border: 1px solid rgb(252, 100, 35) !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relevant to #734. Please, test carefully before make changes like this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A mistake... I'll move this to styles of Mist&Muse...

@ivan-nginx ivan-nginx mentioned this pull request Mar 25, 2019
Closed
@1v9 1v9 mentioned this pull request Mar 30, 2019
Closed
@ivan-nginx ivan-nginx mentioned this pull request Apr 4, 2019
Closed
11 tasks
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@stevenjoezhang
Remove redundant styles in schedule page and ul > li (theme-next#728)
0a0848e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-nginx ivan-nginx ivan-nginx approved these changes

Assignees
No one assigned
Labels
🛠 Improvement
Projects
None yet
Milestone
v7.1.0
Development

Successfully merging this pull request may close these issues.

Why do not use default list style?
3 participants
@stevenjoezhang @CLAassistant @ivan-nginx