Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arrow function expression #1003

Merged
merged 11 commits into from
Aug 1, 2019
Merged

Arrow function expression #1003

merged 11 commits into from
Aug 1, 2019

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Jul 24, 2019 •
edited by 1v9
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@theme-next theme-next deleted a comment Jul 24, 2019
@theme-next theme-next deleted a comment Jul 30, 2019
@theme-next theme-next deleted a comment Jul 30, 2019
@theme-next theme-next deleted a comment Jul 30, 2019
@stevenjoezhang stevenjoezhang requested review from jiangtj and 1v9 July 30, 2019 09:31
@theme-next theme-next deleted a comment Jul 30, 2019
@theme-next theme-next deleted a comment Jul 30, 2019
@1v9 1v9 closed this Jul 30, 2019
@1v9 1v9 reopened this Jul 30, 2019
@1v9 1v9 marked this pull request as ready for review July 31, 2019 05:54
@1v9 1v9 changed the title Refactor warning messages in build process Arrow function expression Jul 31, 2019
@theme-next theme-next deleted a comment Jul 31, 2019
@stevenjoezhang stevenjoezhang added this to the v7.4.0 milestone Aug 1, 2019
@stevenjoezhang
Copy link
Contributor Author

Arrow function requires Node.js >= 6.

And Hexo is discussing something about NodeJs 6 support:
hexojs/hexo#3508

So this PR should not cause any new problems

@stevenjoezhang stevenjoezhang merged commit 5479a10 into master Aug 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the warn branch August 1, 2019 04:00
@ivan-nginx ivan-nginx mentioned this pull request Aug 1, 2019
Closed
33 tasks
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@stevenjoezhang
Use arrow function expression (theme-next#1003)
72e7318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1v9 1v9 1v9 approved these changes

@ivan-nginx ivan-nginx Awaiting requested review from ivan-nginx

@maple3142 maple3142 Awaiting requested review from maple3142

@sli1989 sli1989 Awaiting requested review from sli1989

@jiangtj jiangtj Awaiting requested review from jiangtj

Assignees
No one assigned
Labels
🛠 Improvement 🎯 Roadmap
Projects
None yet
Milestone
v7.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenjoezhang @1v9