Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix site title's external font family bug #1007

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Fix site title's external font family bug #1007

merged 1 commit into from
Jul 25, 2019

Conversation

leirock
Copy link
Contributor

@leirock leirock commented Jul 25, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

When we set external font family of site title, no change happens.

font:
  enable: true
  title:
    external: true
    family: Caveat
    size:

Issue resolved: N/A

What is the new behavior?

We can set external font family for site title.

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

font:
  enable: true
  title:
    external: true
    family: Caveat
    size:

Does this PR introduce a breaking change?

  • Yes.
  • No.

@1v9 1v9 added this to the v7.3.0 milestone Jul 25, 2019
@1v9 1v9 merged commit 2652203 into theme-next:master Jul 25, 2019
@theme-next theme-next deleted a comment from allcontributors bot Jul 25, 2019
@1v9
Copy link
Member

1v9 commented Jul 25, 2019

@allcontributorsadd please add @lei2rock for doc, bug

@allcontributors
Copy link
Contributor

@1v9

I've put up a pull request to add @lei2rock! 🎉

@stevenjoezhang stevenjoezhang mentioned this pull request Aug 5, 2019
3 tasks
@1v9 1v9 added the 🌀 Fonts label Aug 13, 2019
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants