Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce unnecessary blank lines in templates #1030

Merged
merged 1 commit into from
Jul 29, 2019
Merged

Reduce unnecessary blank lines in templates #1030

merged 1 commit into from
Jul 29, 2019

Conversation

stevenjoezhang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@stevenjoezhang
Copy link
Contributor Author

With this PR, approximately 1800 lines of HTML were reduced to 1200 lines.

@stevenjoezhang stevenjoezhang requested review from jiangtj and 1v9 July 29, 2019 05:20
@stevenjoezhang stevenjoezhang added this to the v7.3.0 milestone Jul 29, 2019
@stevenjoezhang stevenjoezhang merged commit d57fb96 into master Jul 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the space branch July 29, 2019 08:25
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@stevenjoezhang
Reduce unnecessary blank lines in templates (theme-next#1030)
b99a398
stevenjoezhang referenced this pull request in next-theme/hexo-theme-next Nov 19, 2020
@stevenjoezhang
Remove extra blank lines
2eabd8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1v9 1v9 1v9 approved these changes

@ivan-nginx ivan-nginx Awaiting requested review from ivan-nginx

@maple3142 maple3142 Awaiting requested review from maple3142

@sli1989 sli1989 Awaiting requested review from sli1989

@jiangtj jiangtj Awaiting requested review from jiangtj

Assignees
No one assigned
Labels
🛠 Improvement
Projects
None yet
Milestone
v7.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenjoezhang @1v9