Make font-size customized only when theme.font.enable is true
#1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
ivan-nginx,
maple3142,
sli1989 and
stevenjoezhang
stevenjoezhang
approved these changes
Aug 4, 2019
1v9
changed the title
theme.font.enable
1v9
changed the title
theme.font.enabletheme.font.enable is true
ivan-nginx
requested changes
Aug 5, 2019
|
@stevenjoezhang are u think this is good? Because font-size and font-family – independence options. |
|
@ivan-nginx In my opinion, |
|
The current situation is consistent with documentation: Lines 478 to 481 in 2637c53 Maybe it would be better to keep it as is? |
stevenjoezhang
approved these changes
Oct 14, 2019
Liam0205
added a commit
to Liam0205/hexo-theme-next
that referenced
this pull request
Oct 22, 2019
- Add Google Analytics Pageview (theme-next#1198) - Make font-size customized only when `theme.font.enable` is true (theme-next#1058) - Point to different website based on the scheme (theme-next#1202) - New Valine options (theme-next#1193) - Improve the style of site-nav (theme-next#1180) - Code style update (theme-next#1197, theme-next#1205) - Replace id with class name (theme-next#1209) - Add lang attribute to article tag when specified in front matter (theme-next#1199) - Fix compatibility issues with hexo-util@1.3.0 (theme-next#1175) - Optimize the loading of three.js (theme-next#1140) - New README for NexT (theme-next#1155) *** For full changes, see the [comparison between v7.4.1 and v7.5.0](theme-next/hexo-theme-next@v7.4.1...v7.5.0)
tongluyang
pushed a commit
to tongluyang/hexo-theme-next
that referenced
this pull request
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue resolved: N/A
What is the new behavior?
How to use?
In NexT
_config.yml:Does this PR introduce a breaking change?