Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange bug with symlinked next dir #1062

Merged
merged 1 commit into from
Aug 6, 2019
Merged

Strange bug with symlinked next dir #1062

merged 1 commit into from
Aug 6, 2019

Conversation

ivan-nginx
Copy link
Member

@ivan-nginx ivan-nginx commented Aug 5, 2019

Fix for strange bug if next directory will be placed under symlink in theme → Error: Cannot find module 'lodash/merge'. Releated to #1043.

Steps to reproduce

  1. Open hexo/themes
  2. Move next physical directory somewhere else, for example /home/username
  3. Create symlink in themes dir: ln -s /home/username/next hexo/themes/next-symlink

And get something like that:

image

@ivan-nginx ivan-nginx added this to the v7.4.0 milestone Aug 5, 2019
@1v9
Copy link
Member

1v9 commented Aug 5, 2019

Merge?

@ivan-nginx
Copy link
Member Author

Maybe someone will find better variant with path (hexo.base_dir + 'node_modules/lodash/merge). Don't rush.

@ivan-nginx
Copy link
Member Author

@theme-next/next so, if not exists any better suggestions for now, need to merge it.

@1v9 1v9 merged commit 3f43d29 into master Aug 6, 2019
@delete-merged-branch delete-merged-branch bot deleted the symlinked-next branch August 6, 2019 17:56
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants