Use nunjucks-compatible syntax & operator #1068

stevenjoezhang · 2019-08-05T15:40:16Z

Swig-template supports || && or and
nunjucks only supports or and

mozilla/nunjucks#622

1v9 · 2019-08-05T16:28:00Z

Maybe need a new label for code style change.

ivan-nginx · 2019-08-05T17:58:05Z

Let's up this set on v8.x? I think no need on v7.

ivan-nginx · 2019-08-05T23:23:26Z

https://github.com/popomore/nunjucks-vs-swig

GitHub
popomore/nunjucks-vs-swig
Contribute to popomore/nunjucks-vs-swig development by creating an account on GitHub.

stevenjoezhang · 2019-08-06T03:07:20Z

See also: hexojs/hexo#2903

ivan-nginx · 2019-08-06T03:10:37Z

Need to rename *.swig on *njk also, I think.

stevenjoezhang · 2019-08-06T03:19:36Z

Yes, we could do this after Hexo drops swig support. The syntax of these two template engines is similar, except for some minor differences:
json_encode -> dump

cd layout
find . -name "*.swig" -exec rename 's/\.swig$/.njk/' '{}' \;

stevenjoezhang · 2019-08-06T17:00:58Z

@ivan-nginx @1v9 I tried to use hexo-renderer-njucks, but got a strange error:

ERROR Template render error: (/Users/StevenJoeZhang/blog/themes/next/layout/tag.njk) [Line 46, Column 4]
  unknown block tag: endfor
Template render error: (/Users/StevenJoeZhang/blog/themes/next/layout/tag.njk) [Line 46, Column 4]
  unknown block tag: endfor
    at Object._prettifyError (/Users/StevenJoeZhang/blog/node_modules/nunjucks/src/lib.js:36:11)
    at /Users/StevenJoeZhang/blog/node_modules/nunjucks/src/environment.js:567:19
    at eval (eval at _compile (/Users/StevenJoeZhang/blog/node_modules/nunjucks/src/environment.js:637:18), <anonymous>:19:11)
    at Template.getExported (/Users/StevenJoeZhang/blog/node_modules/nunjucks/src/environment.js:605:16)
    at eval (eval at _compile (/Users/StevenJoeZhang/blog/node_modules/nunjucks/src/environment.js:637:18), <anonymous>:18:5)
    at createTemplate (/Users/StevenJoeZhang/blog/node_modules/nunjucks/src/environment.js:315:9)
    at handle (/Users/StevenJoeZhang/blog/node_modules/nunjucks/src/environment.js:327:11)
    at /Users/StevenJoeZhang/blog/node_modules/nunjucks/src/environment.js:339:9
    at next (/Users/StevenJoeZhang/blog/node_modules/nunjucks/src/lib.js:280:7)
    at Object.asyncIter (/Users/StevenJoeZhang/blog/node_modules/nunjucks/src/lib.js:286:3)
    at Environment.getTemplate (/Users/StevenJoeZhang/blog/node_modules/nunjucks/src/environment.js:321:9)
    at eval (eval at _compile (/Users/StevenJoeZhang/blog/node_modules/nunjucks/src/environment.js:637:18), <anonymous>:16:5)
    at createTemplate (/Users/StevenJoeZhang/blog/node_modules/nunjucks/src/environment.js:315:9)
    at handle (/Users/StevenJoeZhang/blog/node_modules/nunjucks/src/environment.js:327:11)
    at /Users/StevenJoeZhang/blog/node_modules/nunjucks/src/environment.js:339:9
    at next (/Users/StevenJoeZhang/blog/node_modules/nunjucks/src/lib.js:280:7)
    at Object.asyncIter (/Users/StevenJoeZhang/blog/node_modules/nunjucks/src/lib.js:286:3)
    at Environment.getTemplate (/Users/StevenJoeZhang/blog/node_modules/nunjucks/src/environment.js:321:9)
    at Template.root [as rootRenderFunc] (eval at _compile (/Users/StevenJoeZhang/blog/node_modules/nunjucks/src/environment.js:637:18), <anonymous>:9:5)
    at Template.render (/Users/StevenJoeZhang/blog/node_modules/nunjucks/src/environment.js:556:10)
    at /Users/StevenJoeZhang/blog/node_modules/hexo-renderer-njucks/index.js:22:27
    at Theme._View.View._compiled (/Users/StevenJoeZhang/blog/node_modules/hexo/lib/theme/view.js:123:48)
    at Theme._View.View.View.render (/Users/StevenJoeZhang/blog/node_modules/hexo/lib/theme/view.js:29:15)
    at /Users/StevenJoeZhang/blog/node_modules/hexo/lib/hexo/index.js:349:21
    at tryCatcher (/Users/StevenJoeZhang/blog/node_modules/bluebird/js/release/util.js:16:23)
    at /Users/StevenJoeZhang/blog/node_modules/bluebird/js/release/method.js:15:34
    at RouteStream._read (/Users/StevenJoeZhang/blog/node_modules/hexo/lib/hexo/router.js:123:3)
    at RouteStream.Readable.read (_stream_readable.js:474:10)

I have no idea why endfor tag is not parsed correctly. Migrate to nunjucks is not easy as changing the suffix name...

So, this PR works fine, but another PR is needed to handle the nunjucks syntax

1v9 · 2019-08-06T17:54:35Z

Hexo hasn't toally switched to nunjucks, but tag plugin used nunjucks to render.

stevenjoezhang · 2019-08-06T17:56:18Z

Yes, so you have to install the plugin first: hexo-renderer-njucks

1v9 · 2019-08-06T17:59:35Z

These nunjucks plugins maintenance is not stable enough, so just wait hexojs/hexo#2903 finished and merged and more...

ivan-nginx · 2019-08-07T03:27:34Z

hexo-renderer-njucks

There are 3 or maybe more nunjucks plugins, not all in public Hexo directory.

stevenjoezhang · 2019-08-07T03:30:41Z

In fact none is in public Hexo directory. They are all 3rd-party plugin. And I choose the only one that still maintained...

ivan-nginx · 2019-08-07T03:32:16Z

BTW, mb we can create own nunjucks plugin and make him internal in scripts dir?

ivan-nginx · 2019-08-07T03:33:18Z

And I choose the only one that still maintained...

Which plugin u choose?

stevenjoezhang · 2019-08-07T03:35:19Z

This one: https://github.com/AlynxZhou/hexo-renderer-nunjucks
In its README:

Both hexo-renderer-nunjucks and hexo-renderer-njk and hexo-renderer-njks are using Nunjucks version 2, and seems their author won't update them to Nunjucks 3. They take the best name in npm, but leave code unmaintained! So I write my own hexo renderer to render my theme ARIA.

GitHub
AlynxZhou/hexo-renderer-nunjucks
Yet another Nunjucks renderer for Hexo. Contribute to AlynxZhou/hexo-renderer-nunjucks development by creating an account on GitHub.

stevenjoezhang · 2019-08-07T03:36:07Z

mb we can create own nunjucks plugin

yes, we can just put it in the scripts dir

ivan-nginx · 2019-08-07T03:36:57Z

mb we can create own nunjucks plugin
yes, we can just put it in the scripts dir

So, we must find all possible plugins and create from them the best one.

ivan-nginx · 2019-08-07T03:41:10Z

Also, we can no rename swig extension; we can just add swig to nunjucks renderer, that's all.

stevenjoezhang · 2019-08-07T04:30:14Z

We can't migrate to njk unless we clearly understands the problem
#1068 (comment)

* Replace && with and * Replace || with or * Replace ! with not * Use ES6 includes method

stevenjoezhang added 2 commits August 5, 2019 23:20

Replace && / || with and / or

99056cb

Replace

c92c44b

1v9 approved these changes Aug 5, 2019

View reviewed changes

1v9 added the 🛠 Improvement label Aug 5, 2019

1v9 added this to the v7.4.0 milestone Aug 5, 2019

ivan-nginx modified the milestones: v7.4.0, v8.0.0 Aug 5, 2019

stevenjoezhang added 2 commits August 7, 2019 00:44

Update

ab30751

RSS

ab103c5

stevenjoezhang changed the title ~~Replace && / || operator with and / or~~ Use nunjucks-compatible syntax & operator Aug 6, 2019

ivan-nginx added 🔌 3rd Party Plugin 🚧 Work in Progress labels Aug 7, 2019

stevenjoezhang removed the 🚧 Work in Progress label Aug 13, 2019

stevenjoezhang modified the milestones: v8.0.0, v7.4.0 Aug 14, 2019

stevenjoezhang added 7 commits August 18, 2019 22:03

Merge branch 'master' into operator

9456435

Merge branch 'master' into operator

e01efac

RSS

1b9da1f

Update

11e69e0

Back

e2a4444

Merge branch 'master' into operator

2173d70

Update

af4b8b4

1v9 modified the milestones: v7.4.0, v8.0.0 Aug 31, 2019

Includes & not

74abdf1

stevenjoezhang modified the milestones: v8.0.0, v7.4.1 Aug 31, 2019

Merge branch 'master' into operator

ed72dbf

stevenjoezhang merged commit abd45df into master Sep 1, 2019

delete-merged-branch bot deleted the operator branch September 1, 2019 02:22

stevenjoezhang mentioned this pull request Sep 8, 2019

Consider to change your template engine. #1161

Closed

8 tasks

ivan-nginx mentioned this pull request Oct 2, 2019

NexT v7.5 Roadmap #809

Closed

33 tasks

1v9 added the Template Engine label Oct 14, 2019

stevenjoezhang mentioned this pull request Oct 16, 2019

Migrate to Nunjucks #1214

Closed

13 tasks

tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019

Use nunjucks-compatible syntax & operator (theme-next#1068)

ed109c0

* Replace && with and * Replace || with or * Replace ! with not * Use ES6 includes method

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use nunjucks-compatible syntax & operator #1068

Use nunjucks-compatible syntax & operator #1068

stevenjoezhang commented Aug 5, 2019

1v9 commented Aug 5, 2019

ivan-nginx commented Aug 5, 2019

ivan-nginx commented Aug 5, 2019 •

edited

Loading

stevenjoezhang commented Aug 6, 2019

ivan-nginx commented Aug 6, 2019

stevenjoezhang commented Aug 6, 2019 •

edited

Loading

stevenjoezhang commented Aug 6, 2019

1v9 commented Aug 6, 2019

stevenjoezhang commented Aug 6, 2019

1v9 commented Aug 6, 2019

ivan-nginx commented Aug 7, 2019 •

edited

Loading

stevenjoezhang commented Aug 7, 2019

ivan-nginx commented Aug 7, 2019

ivan-nginx commented Aug 7, 2019

stevenjoezhang commented Aug 7, 2019 •

edited by unfurl-links bot

Loading

stevenjoezhang commented Aug 7, 2019 •

edited

Loading

ivan-nginx commented Aug 7, 2019

ivan-nginx commented Aug 7, 2019

stevenjoezhang commented Aug 7, 2019

Use nunjucks-compatible syntax & operator #1068

Use nunjucks-compatible syntax & operator #1068

Conversation

stevenjoezhang commented Aug 5, 2019

1v9 commented Aug 5, 2019

ivan-nginx commented Aug 5, 2019

ivan-nginx commented Aug 5, 2019 • edited Loading

stevenjoezhang commented Aug 6, 2019

ivan-nginx commented Aug 6, 2019

stevenjoezhang commented Aug 6, 2019 • edited Loading

stevenjoezhang commented Aug 6, 2019

1v9 commented Aug 6, 2019

stevenjoezhang commented Aug 6, 2019

1v9 commented Aug 6, 2019

ivan-nginx commented Aug 7, 2019 • edited Loading

stevenjoezhang commented Aug 7, 2019

ivan-nginx commented Aug 7, 2019

ivan-nginx commented Aug 7, 2019

stevenjoezhang commented Aug 7, 2019 • edited by unfurl-links bot Loading

stevenjoezhang commented Aug 7, 2019 • edited Loading

ivan-nginx commented Aug 7, 2019

ivan-nginx commented Aug 7, 2019

stevenjoezhang commented Aug 7, 2019

ivan-nginx commented Aug 5, 2019 •

edited

Loading

stevenjoezhang commented Aug 6, 2019 •

edited

Loading

ivan-nginx commented Aug 7, 2019 •

edited

Loading

stevenjoezhang commented Aug 7, 2019 •

edited by unfurl-links bot

Loading

stevenjoezhang commented Aug 7, 2019 •

edited

Loading