-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix leancloud counter bug #1093
Conversation
Thanks so much for opening your first PR here! |
@littleylv Can you confirm that? Seems that the Response body is the same after this PR Request URL: https://piu0nmph.api.lncldglobal.com/1.1/classes/Counter?{%22where%22:%22/2019-08/%E5%A4%B1%E5%8E%BB%E5%90%8C%E6%AD%A5/%22} Request URL: https://piu0nmph.api.lncldglobal.com/1.1/classes/Counter?where={%22url%22:%22/2019-08/%E5%A4%B1%E5%8E%BB%E5%90%8C%E6%AD%A5/%22} |
@stevenjoezhang Yes, you can check my blog here: https://littleylv.github.io/2016/01/new-post/ https://mxgxbwwf.api.lncldglobal.com/1.1/classes/Counter?{%22where%22:%22/2016/01/new-post/%22} which means query key is
|
@littleylv Thanks. Maybe you can use |
@stevenjoezhang I don't think so. I should just revert it to the older version before cbf6041 |
Congrats on merging your first pull request here! 🎉 How awesome! |
@all-contributors please add @littleylv for bug |
I've put up a pull request to add @littleylv! 🎉 |
PR Type
What is the current behavior?
Bug from this commit: cbf6041#diff-d4f96cf2cea92b9d7c8d95bb034e2eb2R13
In post page, cleancloud counter api returns all data then use the first item
var counter = results[0];
What is the new behavior?
In post page, cleancloud counter api returns current url correctly.
Does this PR introduce a breaking change?