Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract all share systems to plugins #1104

Merged
merged 5 commits into from
Aug 18, 2019
Merged

Extract all share systems to plugins #1104

merged 5 commits into from
Aug 18, 2019

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Aug 16, 2019 •
edited
Loading

@stevenjoezhang stevenjoezhang changed the title Extract all share system to plugin Extract all share systems to plugins Aug 16, 2019
@stevenjoezhang stevenjoezhang mentioned this pull request Aug 16, 2019
Merged
ivan-nginx
ivan-nginx reviewed Aug 16, 2019
View reviewed changes
Copy link
Member

@ivan-nginx ivan-nginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally remove likely?

@stevenjoezhang
Copy link
Contributor Author

stevenjoezhang commented Aug 16, 2019 •
edited
Loading

Not removing. Will create a new plugin using theme-inject.

https://github.com/theme-next/hexo-next-share

@ivan-nginx
Copy link
Member

Ok then...

@stevenjoezhang stevenjoezhang marked this pull request as ready for review August 17, 2019 00:43
@stevenjoezhang stevenjoezhang added this to the v7.4.0 milestone Aug 17, 2019
@1v9 1v9 removed the ⭐ Feature label Aug 17, 2019
@stevenjoezhang
Copy link
Contributor Author

Docs here: theme-next/theme-next.org#75

@stevenjoezhang stevenjoezhang merged commit 8724c65 into master Aug 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the share branch August 18, 2019 14:04
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@stevenjoezhang
Extract all content sharing services to plugins (theme-next#1104)
624526d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-nginx ivan-nginx ivan-nginx left review comments

@maple3142 maple3142 Awaiting requested review from maple3142

@sli1989 sli1989 Awaiting requested review from sli1989

Assignees
No one assigned
Labels
💥 Breaking Change
Projects
None yet
Milestone
v7.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenjoezhang @ivan-nginx @1v9