Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflict between animation of sub-menu icons and pjax #1349

Merged
merged 2 commits into from
Jan 14, 2020
Merged

Fix conflict between animation of sub-menu icons and pjax #1349

merged 2 commits into from
Jan 14, 2020

Conversation

foxB612
Copy link
Contributor

@foxB612 foxB612 commented Jan 12, 2020

PR Checklist

  • The commit message follows guidelines for NexT.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

  • Issue resolved:
    When animation and pjax are both turned on, the sub-menu icons will become invisible after a pjax reload.
  • Reason:
    Sub-menu items have opacity of 0, as defined in css together with menu-item, which need to be animated to opacity 1 by velocity. However sub-menu is also in the part that pjax refreshes, and pjax script overlooks them, resulting in invisibility after pjax reload.
  • A demo (with Pisces): https://foxb612.github.io/sub-menu-bug.gif

What is the new behavior?

Bug fixed.

Does this PR introduce a breaking change?

  • Yes.
  • No.

@welcome
Copy link

welcome bot commented Jan 12, 2020

Thanks so much for opening your first PR here!

@claassistantio
Copy link

claassistantio commented Jan 12, 2020

CLA assistant check
All committers have signed the CLA.

@stevenjoezhang
Copy link
Contributor

Thank you for your contribution! We will investigate and confirm this solution.

@stevenjoezhang stevenjoezhang added this to the 7.8.0 milestone Jan 14, 2020
@stevenjoezhang stevenjoezhang changed the title Fix conflit between animation of sub-menu icons and pjax Fix conflict between animation of sub-menu icons and pjax Jan 14, 2020
@stevenjoezhang stevenjoezhang merged commit c4796bd into theme-next:master Jan 14, 2020
@welcome
Copy link

welcome bot commented Jan 14, 2020

Congrats on merging your first pull request here! 🎉 How awesome!

@foxB612 foxB612 deleted the fix-sub-menu-bug branch January 17, 2020 14:37
voidking pushed a commit to voidking/hexo-theme-next-2021 that referenced this pull request Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants