Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Dark Mode support #1386

Merged
merged 13 commits into from
Feb 23, 2020
Merged

Native Dark Mode support #1386

merged 13 commits into from
Feb 23, 2020

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Feb 21, 2020

Thanks to @1v9 @BillYang2016 and @Yuhhang, this Pull Request was inspired by your dark mode design and implementation.

Some stylus variables are exported as CSS variables, and will no longer be available during customization.

Hello darkness my old friend.
I've come to talk with you again.

@stevenjoezhang stevenjoezhang changed the title Native Dark Mode support [0] Native Dark Mode support Feb 22, 2020
@stevenjoezhang stevenjoezhang requested a review from a team February 22, 2020 12:26
@stevenjoezhang
Copy link
Contributor Author

stevenjoezhang commented Feb 22, 2020

  • Currently, the color of pagination has not been replaced.

https://github.com/1v9/hexo-next-nightmode/blob/a0b95c098a7476ba18c9b3c80487736678d13724/css/scheme.styl#L68-L72

  • And the color of the buttons under Pisces / Gemini needs to be adjusted.

  • Need more testing.

GitHub
Add Night Mode support for NexT. Contribute to 1v9/hexo-next-nightmode development by creating an account on GitHub.

@stevenjoezhang stevenjoezhang added this to the 7.7.2 milestone Feb 23, 2020
@stevenjoezhang stevenjoezhang merged commit c193b08 into master Feb 23, 2020
@stevenjoezhang stevenjoezhang deleted the darkmode branch February 23, 2020 03:28
@stevenjoezhang stevenjoezhang mentioned this pull request Feb 27, 2020
15 tasks
@asdf2014
Copy link
Member

@stevenjoezhang Can we add a button to switch dark mode?

image

@stevenjoezhang
Copy link
Contributor Author

stevenjoezhang commented Mar 12, 2020

@asdf2014 Use this plugin: https://github.com/sandoche/Darkmode.js

GitHub
🌓 Add a dark-mode / night-mode to your website in a few seconds - sandoche/Darkmode.js

@asdf2014
Copy link
Member

asdf2014 commented Mar 12, 2020

@stevenjoezhang Thanks a lot. It worked. https://yuzhouwan.com/

5DD2BFD5-3035-49A0-B232-2CB4D61EE614

宇宙湾
Benedict Jin's Blog

@FgSurewin
Copy link

@stevenjoezhang Thanks a lot. It worked. https://yuzhouwan.com/

5DD2BFD5-3035-49A0-B232-2CB4D61EE614

宇宙湾**宇宙湾**Benedict Jin's Blog

Could you mind sharing how to how to use that dark button plugin? As I am new to hexo, I don't know how to insert a js file into swig file.

@wangzhe3224
Copy link

Can we set a force dark mode instead of dark mode depending on user's system theme? Because it seems dark mode is no activated even I use a dark theme in Ubuntu 19. Thanks

@stevenjoezhang
Copy link
Contributor Author

Sorry, we have no plans to add this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants