Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize #274 Custom logo for Gemini & Pisces #520

Merged
merged 3 commits into from
Dec 21, 2018
Merged

Reorganize #274 Custom logo for Gemini & Pisces #520

merged 3 commits into from
Dec 21, 2018

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Dec 19, 2018 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes have been added (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs have been added / updated (for bug fixes / features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue Number(s): #274

What is the new behavior?

Description about this pull, in several words...

2018-12-19 11 41 51

Custom logo for Gemini & Pisces

  • Screens with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

custom_logo:
  enabled: true
  image: /path/to/your/logo.jpg

Does this PR introduce a breaking change?

  • Yes.
  • No.

ivan-nginx
ivan-nginx requested changes Dec 19, 2018
View reviewed changes
Copy link
Member

@ivan-nginx ivan-nginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix Codacy errors.

@stevenjoezhang stevenjoezhang changed the title Reorganize #274 Reorganize #274 Custom logo for Gemini & Pisces Dec 19, 2018
@theme-next theme-next deleted a comment Dec 19, 2018
@stevenjoezhang
Copy link
Contributor Author

stevenjoezhang commented Dec 19, 2018 •
edited
Loading

It seems the problem comes from (NexT.utils.isPisces() || NexT.utils.isGemini()) && hasElement($image) && pushImageToSequence(); in source/js/src/motion.js. But I don't know how to fix it😂 Do you have any good idea?

@ivan-nginx
Copy link
Member

I'll check it tomorrow.

@stevenjoezhang stevenjoezhang mentioned this pull request Dec 20, 2018
Closed
5 tasks
@ivan-nginx ivan-nginx added this to the v6.7.0 milestone Dec 20, 2018
@ivan-nginx ivan-nginx merged commit 979bc69 into theme-next:master Dec 21, 2018
ivan-nginx
ivan-nginx reviewed Dec 21, 2018
View reviewed changes
Copy link
Member

@ivan-nginx ivan-nginx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@stevenjoezhang stevenjoezhang mentioned this pull request Aug 21, 2019
Closed
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@stevenjoezhang @ivan-nginx
Reorganize theme-next#274 Custom logo for Gemini & Pisces (theme-next…
d39a220 
…#520)

* Reorganize theme-next#274

* motion

* bug fix
stevenjoezhang referenced this pull request in next-theme/hexo-theme-next Jun 6, 2020
@stevenjoezhang
Optimize the style of custom-logo and sidebar-inner
d194052
wens07 pushed a commit to wens07/hexo-theme-next that referenced this pull request May 8, 2023
@icpz
Fix double quotes inside cloudflare analytics HTML attribute (theme-n…
296edd3 
…ext#520)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-nginx ivan-nginx ivan-nginx requested changes

Assignees
No one assigned
Labels
⭐ Feature
Projects
None yet
Milestone
v6.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenjoezhang @ivan-nginx